Mismatch between specification and testdata for tensor literals

[jtristan]

What happened?

Many programs in testdata declare tensor literals with a syntax of the form dense<"0x29C0C7404">, which is not mentioned in the specification. Example.

The actual syntax seems to be something like:

TensorLiteral  ::= 'dense' '<' (DenseLiteral | ElementLiteral | CompactHexaStringLiteral) '>'
CompactHexaStringLiteral ::= '"' '0x' HexadecimalDigits '"'

but I am inferring this from testdata programs and I would like to know if this is indeed general enough or if I am missing other patterns that are not present in testdata.

While I mention the TensorConstant grammar, note that the current grammar

TensorConstant ::= TensorLiteral ':' TensorType
TensorLiteral  ::= 'dense' '<' (DenseLiteral | ElementLiteral) '>'
DenseLiteral   ::= DenseDimension | DenseElements
DenseDimension ::= '[' [DenseLiteral {',' DenseLiteral}] ']'
DenseElements  ::= [ElementLiteral {',' ElementLiteral}]
ElementLiteral ::= BooleanLiteral | IntegerLiteral | FloatLiteral | ComplexLiteral

allows to derive a term like dense <3.2> in two ways:
TensorLiteral -> ElementLiteral -> FloatLiteral
or TensorLiteral -> DenseLiteral -> DenseElements -> ElementLiteral -> FloatLiteral

and could be simplified to:

TensorConstant ::= TensorLiteral ':' TensorType
TensorLiteral  ::= 'dense' '<' DenseLiteral '>'
DenseLiteral   ::= DenseDimension | DenseElements
DenseDimension ::= '[' [DenseLiteral {',' DenseLiteral}] ']'
DenseElements  ::= [ElementLiteral {',' ElementLiteral}]
ElementLiteral ::= BooleanLiteral | IntegerLiteral | FloatLiteral | ComplexLiteral

Steps to reproduce your issue

No response

Version information

73b0862