Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing dimensions from MapOp #487

Closed
ghpvnist opened this issue Nov 8, 2022 · 2 comments
Closed

Consider removing dimensions from MapOp #487

ghpvnist opened this issue Nov 8, 2022 · 2 comments
Labels
Spec Verification

Comments

@ghpvnist
Copy link
Member

ghpvnist commented Nov 8, 2022

MapOp has dimensions attributes which is not used by the op currently since it only supports scalar map functions. Currently, all dimensions need to be provided, but there is no benefit in having them.
@ghpvnist ghpvnist mentioned this issue Nov 8, 2022
Merged
@ghpvnist ghpvnist added the Migrate to MHLO PR that needs to be migrated to MLIR-HLO label Nov 8, 2022
@burmako burmako removed Migrate to MHLO PR that needs to be migrated to MLIR-HLO Verification labels Nov 8, 2022
@burmako burmako changed the title Remove dimensions attribute from MapOp Consider removing dimensions attribute from MapOp Nov 8, 2022
@burmako
Copy link
Contributor

burmako commented Nov 25, 2022

For the record, hlo_instruction.cc doesn't support dimensions.

@sdasgup3 sdasgup3 mentioned this issue Feb 7, 2023
Merged
@burmako burmako changed the title Consider removing dimensions attribute from MapOp Consider removing dimensions from MapOp Mar 9, 2023
@GleasonK
Copy link
Member

Closing in favor of #2340 which proposes to remove MapOp all together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec Verification
Projects
Frontend contract
Status: Done
StableHLO v1.0 Release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@burmako @GleasonK @ghpvnist