Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch names with "/" are revoked on the nightly.link page #27

Closed
dyfer opened this issue Aug 7, 2021 · 2 comments
Closed

branch names with "/" are revoked on the nightly.link page #27

dyfer opened this issue Aug 7, 2021 · 2 comments

Comments

@dyfer
Copy link

dyfer commented Aug 7, 2021

Hello,
Thank you for this wonderful tool!
I have found, that branch names that contain / character don't pass format check when entered in the entry box on the nightly.link website.

A workaround is to replace / with e.g. -, and then, after clicking "Get Link", replace back the appropriate character directly in the address bar of the browser.
EDIT: the workaround doesn't seem to actually work, I can't get artifacts from a branch that has a space in it. Example: https://nightly.link/dyfer/supercollider/workflows/actions/topic/macos-legacy-fixes-rebased

@oprypin
Copy link
Owner

oprypin commented Aug 12, 2021

Thanks for the report. The pattern will be recognized in the input correctly now. And the branch with slash was already possible to use but the slash needs to be escaped as such:

https://nightly.link/dyfer/supercollider/workflows/actions/topic%2Fmacos-legacy-fixes-rebased

Unfortunately then we still run into issue #26

That link gives you an empty result
because GitHub reports an empty result
https://github.com/dyfer/supercollider/actions?query=event%3Apush+is%3Asuccess+branch%3Atopic%2Fmacos-legacy-fixes-rebased
even though a slightly modified search clearly shows that there have, in fact, been successful builds:
https://github.com/dyfer/supercollider/actions?query=event%3Apush+branch%3Atopic%2Fmacos-legacy-fixes-rebased

@dyfer
Copy link
Author

dyfer commented Aug 13, 2021

Thank you for looking into this!
I understand that GitHub still reports wrong information. Do you know in what circumstances this happens? Is it due to dashes in the branch name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants