-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDOS Output Gets muddled with Labelled Atoms i.e. C:exi #31
Comments
The convention for specifying which pdos you want to separate the atoms you're interested in with a colon. If a colon is included in the atom name (for example to distinguish an atoms with a corehole) it's not compatible with the pdos string reading. In addition, when putting pdos : species_ang to plot out the angular momentum resolved pdos as a work around, the atomic sites were incorrectly labelled in the output file *.pdos.dat - this may have been a consequence of having a colon in the atom name. |
I think Optados should accept atom symbols given between quote marks. This would prevent any special characters in those strings being misinterpreted. E.g. "C" or "C:ext" - this should be a minor change to Optados, and requires no change to castep. |
I think it's not as minor as it first appears. Sure we can change the PDOS string to accept "C:ext"(s), but I don't think Optados knows about species names at all internally. |
cell knows about symbols and labels - at it needs to parse the cell file. From the CASTEP viewpoint:
in the cell file. These labels appear in CASTEP output, and can be referred to in say, applying constraints. But labels don't break symmetry - and the above two atoms belong to the same species. Two cases: 6 Cr atoms: Cr:1 Cr:2 Cr:1 Cr:2 Cr:1 Cr:2 In the first case we might expect C to match on the first 9 atoms, but not the 10th. And "C:corehole" would match on the 10th Could an unquoted string match on the symbol, and a quoted one match on the label? So in the first example C would match 10 atoms, and "C" would match 9? |
RJN to give more details and examples.
The text was updated successfully, but these errors were encountered: