From d17764b742b5eed0c07f7248dda5aa4ee26837f8 Mon Sep 17 00:00:00 2001 From: Jack Robertson Date: Mon, 18 Feb 2019 14:33:42 +0000 Subject: [PATCH] Naming --- tests/Feature/ConversionManagerTest.php | 36 ------------------------- tests/HasMediaTest.php | 2 +- tests/ImageManipulatorTest.php | 2 +- 3 files changed, 2 insertions(+), 38 deletions(-) delete mode 100644 tests/Feature/ConversionManagerTest.php diff --git a/tests/Feature/ConversionManagerTest.php b/tests/Feature/ConversionManagerTest.php deleted file mode 100644 index 3455853..0000000 --- a/tests/Feature/ConversionManagerTest.php +++ /dev/null @@ -1,36 +0,0 @@ -register('one', $converter1); - $conversionManager->register('two', $converter2); - - $this->assertEquals($converter1(), $conversionManager->get('one')()); - $this->assertEquals($converter2(), $conversionManager->get('two')()); - } - - public function test_that_converters_cant_be_registered_more_than_once() - { - $converter = function () { - }; - $conversionManager = new ConversionManager(); - $conversionManager->register('first', $converter); - $conversionManager->register('first', $converter); - $converters = $conversionManager->all(); - - $this->assertEquals(1, count($converters)); - } -} diff --git a/tests/HasMediaTest.php b/tests/HasMediaTest.php index faab988..43de4ad 100644 --- a/tests/HasMediaTest.php +++ b/tests/HasMediaTest.php @@ -42,7 +42,7 @@ public function it_can_handle_retrieving_media_from_an_empty_group() } /** @test */ - public function it_can_get_all_of_the_media_in_a_group() + public function it_can_get_all_the_media_in_a_group() { $media = factory(Media::class, 2)->create(); diff --git a/tests/ImageManipulatorTest.php b/tests/ImageManipulatorTest.php index 4aa7436..a5e7a75 100644 --- a/tests/ImageManipulatorTest.php +++ b/tests/ImageManipulatorTest.php @@ -48,7 +48,7 @@ public function it_will_apply_known_conversions() } /** @test */ - public function conversions_can_be_skipped_if_the_converted_file_already_exists() + public function it_can_skip_conversions_if_the_converted_image_already_exists() { $conversionManager = new ConversionManager();