Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find out if composites can have several projects #42

Closed
raquelalegre opened this issue Apr 25, 2016 · 2 comments
Closed

Find out if composites can have several projects #42

raquelalegre opened this issue Apr 25, 2016 · 2 comments
Assignees

Comments

@raquelalegre
Copy link
Contributor

raquelalegre commented Apr 25, 2016

Nammu needs to read the project from a parsed ATF. The way it was doing it so far was like this:

parsed_atf = self.parse(nammu_text)
project = parsed_atf.text.project

However this only works for non composites, since composites can have more than one text element, each having it's own PROJECT token.

I haven't looked through the whole corpus but had a look at several of the composites and all the texts inside seem to belong to the same project.

When sending the SOAP envelope for the validation, one project name needs to be specified, so it makes sense it is unique through the file, although it doesn't make sense the original ORACC grammar includes the PROJECT token in all elements of a composite if it's going to be the same.

Need to clarify this with Steve/Eleanor to make sure the contents of the soap envelope are correct.

@jenshnielsen
Copy link
Contributor

This is not actually an issue as such but a misunderstanding of terms
Composites are marked with @composite and only contains one project line the files
with more than one project line are a gathering of small files. And they always have the same project. See #51 @raquel-ucl I think this can close?

@raquelalegre
Copy link
Contributor Author

Yep. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants