-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adios2-config cxxflags output missing "-I" or "-isystem" #4350
Comments
Update:
This suggests that both issues (possibly related, although I can't see how they would be) stem from changes between 2.9.2 and 2.10.0. For more information regarding the MPI link issue, the build of 2.10.0 fails with
My first thought was that this issue would affect every binary but it may also be just |
Describe the bug
I built adios2@2.10.0 via spack on Sunspot using the icpx compiler and found adios2-config does not include the "-I" or "-isystem" prefix to the include path:
A build with gcc and openmpi in a Docker test environment running on a local machine produces the following
which has the "-isystem" prefix.
This missing prefix is preventing libraries using adios2 from being built with spack.
To Reproduce
Here is a complete spack environment:
Please note that the adios2 binaries will fail to link due to the following issue:
suggesting one of the dependent libraries on this system includes MPI symbols for some reason. A workaround is to hack the spack package (var/spack/repos/builtin/packages/adios2/package.py) to include the following
args.append("-DCMAKE_EXE_LINKER_FLAGS=-Wl,-rpath=/opt/aurora/24.086.0/CNDA/mpich/20231026/mpich-ofi-all-icc-default-pmix-gpu-drop20231026/lib/ -L/opt/aurora/24.086.0/CNDA/mpich/20231026/mpich-ofi-all-icc-default-pmix-gpu-drop20231026/lib/ -lmpi")
when putting together the cmake args.
Expected behavior
The output of "adios2-config --cxx-flags" should include "-I" or "-isystem" before the include path
Desktop:
oneapi@2024.04.15.002 cmake cmake@3.27.7
built via spack with specadios2@2.10.0%oneapi@2024.04.15.002 cflags='-fp-model=precise' cxxflags='-fp-model=precise' fflags='-fp-model=precise' ~aws+blosc2+bzip2~campaign~cuda~dataspaces+fortran~hdf5~ipo~kokkos+libcatalyst~libpressio+mgard+mpi~pic+png~python~rocm+sst~sycl+sz+zfp build_system=cmake build_type=Release generator=make arch=linux-sles15-x86_64
The text was updated successfully, but these errors were encountered: