Extend is_invertible_with_inverse to rings of type MPolyQuoRing{<:MPolyDecRingElem}
#4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MPolyDecRingElem}`
|
I added an example from intersection theory where the extension is needed. |
joschmitt
reviewed
Oct 22, 2024
lgoettgens
changed the title
is_invertible_with_inverse to rings of type `MPolyQuoRing{<:…is_invertible_with_inverse to rings of type MPolyQuoRing{<:MPolyDecRingElem}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4226 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 631 631
Lines 85009 85012 +3
=======================================
+ Hits 71908 71911 +3
Misses 13101 13101
|
|
O.k. from my side if lights are green |
fieker
approved these changes
Oct 23, 2024
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Oct 30, 2024
…MPolyDecRingElem}` (oscar-system#4226) * Extend `is_invertible_with_inverse` to rings of type `MPolyQuoRing{<:MPolyDecRingElem}` * correction * Adressing remark by @joschmitt * correction * add extended function to docu * correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…MPolyDecRingElem}`