Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuadFormAndIsom: add a missing check and remove some unnecessary @req #4262

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

StevellM
Copy link
Member

No description provided.

@StevellM StevellM changed the title QuadFormAndIsom: add a missing chech and remove some unnecessary @req QuadFormAndIsom: add a missing check and remove some unnecessary @req Oct 31, 2024
@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (4ab6f4d) to head (5f77a8f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4262      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         640      640              
  Lines       85117    85118       +1     
==========================================
- Hits        72011    72010       -1     
- Misses      13106    13108       +2     
Files with missing lines Coverage Δ
experimental/QuadFormAndIsom/src/embeddings.jl 96.62% <100.00%> (ø)
experimental/QuadFormAndIsom/src/enumeration.jl 93.68% <100.00%> (+0.01%) ⬆️
experimental/QuadFormAndIsom/test/runtests.jl 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All checks are still there, but the change now allows to properly handle return values without catching thrown errors.

@simonbrandhorst simonbrandhorst merged commit eab758a into oscar-system:master Nov 1, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants