Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix Suggestions] Floating Edge Check #405

Open
sayas01 opened this issue Nov 3, 2020 · 2 comments
Open

[Fix Suggestions] Floating Edge Check #405

sayas01 opened this issue Nov 3, 2020 · 2 comments

Comments

@sayas01
Copy link
Collaborator

sayas01 commented Nov 3, 2020

Which Atlas check is the fix suggestion related to?

FloatingEdgeCheck

Description: https://github.com/osmlab/atlas-checks/blob/dev/docs/checks/floatingEdgeCheck.md

Source Code: https://github.com/osmlab/atlas-checks/blob/dev/src/main/java/org/openstreetmap/atlas/checks/validation/linear/edges/FloatingEdgeCheck.java

Describe more details of suggested fix(es)

Suggested Fix 1:

  • Type: Geometry

  • Operation: Delete

  • Action: Remove the floating edge

Is there any code enhancement needed if adding the fix suggestion component?

No

@atiannicelli
Copy link
Collaborator

This seems extreme to me to suggest to delete an edge that is floating. If we suggest to delete it then people may blindly delete edges instead of connecting them properly to another edge.

@Bentleysb
Copy link
Collaborator

I agree with @atiannicelli. I think the fix suggestion case for this check would be to see if there is a nearby Edge and suggest connecting to that. If there are no nearby Edges then the fix would likely be more than we can suggest programmatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants