Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outside collaborators should be override-able at the repo-level #525

Open
pburkholder opened this issue Jun 21, 2024 · 2 comments
Open

Outside collaborators should be override-able at the repo-level #525

pburkholder opened this issue Jun 21, 2024 · 2 comments
Labels
proposal Proposal issue for design and discussion.

Comments

@pburkholder
Copy link

I understand the reasoning behind https://github.com/ossf/allstar/blob/main/pkg/policies/outside/outside.go#L70-L71

// Exemptions are only defined at the org level because they should be made
// obvious to org security managers.

But this makes AllStar hard to scale for organizations that loosely federated, and it's not possible for each product team to necessarily have their own GitHub organization. And I think the needs for org security managers might be better met by #524 which would provide some reporting about where/how overrides are occurring.

I hope next time I can open PRs instead of tickets, but trying to capture some friction points while I can.

@jeffmendoza jeffmendoza added the proposal Proposal issue for design and discussion. label Jun 21, 2024
@jeffmendoza
Copy link
Member

but trying to capture some friction points while I can.

very much appreciated!

@pburkholder
Copy link
Author

The ability to override pushAllowed at the repo level, but not the exempted users, is also a little confounding.

That is, I couldn't get this to work at the org-level:

exemptions:
  - user: Chris-Laurer
    repo: federal-platform-engineering-cop
    push: true
    admin: false
  - user: brianrandallfox
    repo: federal-platform-engineering-cop
    push: true
    admin: false

But I could go ahead with this is at the repo level

pushAllowed: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposal issue for design and discussion.
Projects
None yet
Development

No branches or pull requests

2 participants