feat(develop): add refetch interval to useiceberg hook #13488
Conversation
desc: allow refetchInterval as prop Signed-off-by: Paul Dickerson <paul.dickerson.ext@ovhcloud.com>
pauldkn
force-pushed
the
feat/update-iceberg-hook-params
branch
from
ff5d3c4
to
f3342eb
Compare
|
| interface IcebergV2Hook { | ||
| queryKey: string[]; | ||
| defaultSorting?: ColumnSort; | ||
| refetchInterval?: | ||
| | number | ||
| | false | ||
| | ((query: Query) => number | false | undefined); |
There was a problem hiding this comment.
| interface IcebergV2Hook { | |
| queryKey: string[]; | |
| defaultSorting?: ColumnSort; | |
| refetchInterval?: | |
| | number | |
| | false | |
| | ((query: Query) => number | false | undefined); | |
| interface IcebergV2Hook { | |
| defaultSorting?: ColumnSort; | |
| } extends UndefinedInitialDataInfiniteOptions<IcebergFetchResultV2<T> |
There was a problem hiding this comment.
I think it's good If we can add all query options on params and decompose is on useInfiniteQuery
There was a problem hiding this comment.
I see what you'd like to do, but it goes beyond this issue, doesn't it?
It may have been intentional not to expose every query option on this hook, which is why I'm only requesting the refetchInterval option, the minimum needed here.
However, an issue could certainly be opened to expose every option on icebergV2 or V6 if necessary 👍
There was a problem hiding this comment.
just for your information: in my experience using refreshinterval with useInfiniteQuery without selecting only the actual payload (in data.pages) with select and omitting the page params caused rerenders even if the data didn't changed after refresh (because the cursor changes even tho data is the same) so be careful about that for your use case you might need to use select aswell. And it's even more the case with this hook since there is some state update on every data change which should be conpletely removed
| }); | ||
|
|
||
| useEffect(() => { | ||
| const flatten = data?.pages.map((page) => page.data).flat(); | ||
| const flatten = data?.pages |
There was a problem hiding this comment.
Why not use flatMap() directly ?
github-actions
bot
added
the
has conflicts
desc: allow refetchInterval as prop to the useIceberg hook
Issue 13513
developOnly FR translations have been updatedTicket reference is mentioned in linked commits (internal only)Description
Related