Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings and errors in go report card for ovn kubernetes #4358

Closed
tssurya opened this issue May 15, 2024 · 2 comments
Closed

Fix warnings and errors in go report card for ovn kubernetes #4358

tssurya opened this issue May 15, 2024 · 2 comments
Labels
go Pull requests that update Go code good first issue Issues new contributors can pick up kind/bug All issues that are bugs and PRs opened to fix bugs lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity.

Comments

@tssurya
Copy link
Member

tssurya commented May 15, 2024

What happened?

See https://goreportcard.com/report/github.com/ovn-org/ovn-kubernetes this report for details

What did you expect to happen?

Score for gocyclo and gofmt must be 100%

How can we reproduce it (as minimally and precisely as possible)?

I think running gocyclo and gofmt should be flagging these but apparently the gofmt we run in our CLI doesn't complain of the warnings. Need to look into why that's the case

Anything else we need to know?

No response

OVN Kubernetes version

$ ovnkube --version
Version: 0.3.0
Git commit: f5d4dfb6acef57d9a4cad95fedd672dfe4112f9a
Git branch: master
Go version: go1.21.4
Build date: 2024-05-15
OS/Arch: linux amd64

Kubernetes version

$ kubectl version
Client Version: v1.28.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3

OVN version

$ oc rsh -n ovn-kubernetes ovnkube-node-xxxxx (pick any ovnkube-node pod on your cluster)
$ rpm -q ovn
# paste output here

OVS version

$ oc rsh -n ovn-kubernetes ovs-node-xxxxx (pick any ovs pod on your cluster)
$ rpm -q openvswitch
# paste output here

Platform

KIND cluster

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

@tssurya tssurya added kind/bug All issues that are bugs and PRs opened to fix bugs go Pull requests that update Go code good first issue Issues new contributors can pick up labels May 15, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity. label Jul 16, 2024
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code good first issue Issues new contributors can pick up kind/bug All issues that are bugs and PRs opened to fix bugs lifecycle/stale All issues (> 60 days) and PRs (>90 days) with no activity.
Projects
None yet
Development

No branches or pull requests

1 participant