Support lint rules in vue

[Boshen]

https://github.com/vuejs/core/blob/main/eslint.config.js

[mysteryven]

Rules we need to implement:

• eslint/no-restricted-globals
• eslint/sort-imports
• @typescript-eslint/consistent-type-imports
  • feat(linter): support report @typescript-eslint/consistent-type-imports #3895
  • feat(linter): add fixer for @typescript-eslint/consistent-type-imports #3984
• @typescript-eslint/no-import-type-side-effects
• eslint-plugin-vitest/no-disabled-tests feat(linter): support vitest/no-disabled-tests #3717
• eslint-plugin-vitest/no-focused-tests feat(linter): add vitest/no-focused-tests rule #4178
• eslint/no-restricted-syntax in vuejs/core can be replaced with several rules

{
	"oxc/no-const-enum": "error",
	"oxc/no-async-await": "error",
	"oxc/no-rest-spread-properties": ["error", {
		object_spread_message: "esbuild transpiles object spread into very verbose inline helpers.\n " + 
			"'Please use the `extend` helper from @vue/shared instead.",
		object_rest_message: "Our output target is ES2016, so async/await syntax should be avoided."
	}],
   "no-optional-chaining": [ "error", {
		message: "Our output target is ES2016, and optional chaining results in verbose helpers and should be avoided."
    }]
}

• import-x/no-nodejs-modules can be replaced with prefer_node_protocol

-'import-x/no-nodejs-modules': [
-        'error',
-        { allow: builtinModules.map(mod => `node:${mod}`) },
-   ]
+ 'unicorn/prefer-node-protocol': 'error'

• no-unused-vars also needed, track it on [WIP] feat(linter): add eslint/no-unused-vars #642.

[Boshen]

It seems like we need to support eslint v9 for per directory configuration :-/

files: ['packages/{vue,vue-compat,runtime-dom}/**'],

https://github.com/vuejs/core/blob/main/eslint.config.js

[mysteryven]

Or we can support overrides since our config file is v8.

• ESLint overrides
• Biome overrides

ESLint following the rough steps:

1. Flatten config https://github.com/eslint/eslintrc/blob/59e890fcd9e03663ac185640d5bed5f1a85bd39b/lib/config-array-factory.js#L785-L791
2. Get final config for this file. https://github.com/eslint/eslint/blob/7bcda760369c44d0f1131fccaaf1ccfed5af85f1/lib/linter/linter.js#L1990
3. Get rules according config file https://github.com/eslint/eslint/blob/7bcda760369c44d0f1131fccaaf1ccfed5af85f1/lib/linter/linter.js#L1917

If we convert the config file to a group of thing, and can produce a final config for a specific path, seems like will not change too much for our current codes. But I don't know how much our performance be hurt, as need to generate new config file for each path.(I will take a look at the biome code)

 pub fn run<'a>(&self, ctx: LintContext<'a>) -> Vec<Message<'a>> {
        let semantic = Rc::clone(ctx.semantic());

         // generate new eslint_config files and filter rules here.

		let ctx = ctx.with_fix(self.options.fix).with_eslint_config(&self.eslint_config);
        let rules = self
            .rules
            .iter()
            .map(|rule| {
                (rule, ctx.clone().with_rule_name(rule.name()).with_severity(rule.severity))
            })
            .collect::<Vec<_>>();

        for (rule, ctx) in &rules {
            rule.run_once(ctx);
        }
}

oxc/crates/oxc_linter/src/lib.rs

Lines 102 to 103 in 3016f03

	pub fn run<'a>(&self, ctx: LintContext<'a>) -> Vec<Message<'a>> {
	let semantic = Rc::clone(ctx.semantic());

[DonIsaac]

Ah, No unused vars, my arch enemy, maybe I'll try tackling that for the third time...

[Boshen]

It should be ready after all the recent changes. A simple search through all the unresolved references.

[DonIsaac]

The killer part is all the exceptions, particularly when allowing unused arguments that come before other used/ignored arguments...

Nonetheless I've got a v3 prototype up locally. I'll make a draft PR when it's ready.

[DonIsaac]

What's next up for this?

[drvn-mr]

Could no-unused-vars be supported in Vue <script> code?
I understand the doc mentions .vue files are entirely ignored for the rule since #4716

However oxlint does currently support the files (and JS/TS code) for other rules, excluding the template code.

I guess it was mentioned before: #3370 (comment)

[Sysix]

We need to create an own template-parser to check if is used in vue.
It was requested but not planned for the moment:

https://discord.com/channels/1079625926024900739/1271966101890142278/1272200920041521325