WIP updated the ethereum tests, oyster pearl tests and oyster pearl sim tests #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests in simulated backend.
|
@Astor When you have time can you update this PR so the build will succeed and we can merge it in? |
|
Yes, Will be submitting a new round with fixes for sim and oyster transaction tests |
|
Refactored updates to the contract calls in the unit tests, in addition to the current methods, meaning I didn't change the API and my changes are non-breaking. There was delay due to new subscription addition to the contract calls. |
|
More checks have passed with success for most scenarios getting ready for review. |
|
Resolving conflicts and pushing up the oyster pearl tests update and eth_gateway update as well. |
…t the timing with the test eth network, they depend on setting a timeout, which is 50/50. Finishing the gateway method updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to work out the kinks on the services.RunOnTestNet() method and I pushed this version, prior to adding the oyster pearl sessions for transfer/subscribing for contract events.