Compatibility with node 18

[omerson]

Is the latest version compatible with node 18 lts/hydrogen ?

[mefellows]

It should be, are you having issues?

We test on 16, 18 and 20: https://github.com/pact-foundation/pact-js-core/blob/master/.github/workflows/build-and-test.yml#L71

[omerson]

Thank you for quick reply

I am getting issues:

npm ERR! code 1
npm ERR! path /Users/myhome/code/myproject/node_modules/@pact-foundation/pact-core
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using node-gyp@9.4.0
npm ERR! gyp info using node@18.13.0 | darwin | arm64
npm ERR! gyp info find Python using Python version 3.10.11 found at "/Users/myhome/code/operations/python/venv/bin/python3"
npm ERR! gyp info spawn /Users/myhome/code/operations/python/venv/bin/python3

I am using the latest:
"@pact-foundation/pact": "^12.1.0",

[omerson]

without "@pact-foundation/pact": "^12.1.0", in the package.json it builds with no errors.

[YOU54F]

It shouldn't be the case with the latest version of pact, as the pact-core doesn't contain that file.

Can you check what version of pact-core it has resolved to in your lock file.

can you provide your full package.json or create a reproducible example on GH?

Our pact-js package is tested x platform and cross arch here

https://github.com/pact-foundation/pact-5-minute-getting-started-guide/actions/runs/5787009851

https://github.com/pact-foundation/pact-5-minute-getting-started-guide/runs/15682973538

[omerson]

I am sorry I am not in a position to share the lock file. But the mentioned versions are:

        "@pact-foundation/pact-node": "^10.17.7",
        
        "@pact-foundation/pact": "^12.1.0",

[YOU54F]

you don't need pact-node declared in your package.json, pact contains pact-core (which was formerly known as pact-node)

[omerson]

PS
I also remove node modules

[YOU54F]

can you try with npm install @pact-foundation/pact@latest --ignore-scripts

I'm not sure why node-gyp build is triggering, it shouldn't be, as there is no node-gyp binding file in the published package

[YOU54F]

Running on an m1 mac with node 18.16.0 (arm64 flavour)

🕙22:42:06 ❯ npm install @pact-foundation/pact@latest

added 188 packages, and audited 189 packages in 58s

19 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

🕙22:43:12 ❯ node --version
v18.16.0

🕙22:43:46 ❯ uname -a
Darwin safmacm1.ultrahub 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul  5 22:22:05 PDT 2023; root:xnu-8796.141.3~6/RELEASE_ARM64_T6000 arm64

{
  "name": "foo",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "Yousaf Nabi",
  "license": "ISC",
  "dependencies": {
    "@pact-foundation/pact": "^12.1.0"
  }
}

lock file entries for pact-core and pact with all deps stripped

{
  "name": "foo",
  "version": "1.0.0",
  "lockfileVersion": 3,
  "requires": true,
  "packages": {
    "": {
      "name": "foo",
      "version": "1.0.0",
      "license": "ISC",
      "dependencies": {
        "@pact-foundation/pact": "^12.1.0"
      }
    },
    "node_modules/@pact-foundation/pact": {
      "version": "12.1.0",
      "resolved": "https://registry.npmjs.org/@pact-foundation/pact/-/pact-12.1.0.tgz",
      "integrity": "sha512-jKdltpHTgoWjJim7d+44no9a/4wRrUhQTObQjDZBxBhxEV52JqNstkXZ4bFHkIuWZFD7GOzq4KoApymzifhSTA==",
      "dependencies": {
        "@pact-foundation/pact-core": "^14.0.1",
        "@types/express": "^4.17.11",
        "axios": "^0.27.2",
        "body-parser": "^1.20.0",
        "cli-color": "^2.0.1",
        "express": "^4.18.1",
        "graphql": "^14.0.0",
        "graphql-tag": "^2.9.1",
        "http-proxy": "^1.18.1",
        "js-base64": "^3.6.1",
        "lodash": "^4.17.21",
        "lodash.isfunction": "3.0.8",
        "lodash.isnil": "4.0.0",
        "lodash.isundefined": "3.0.1",
        "lodash.omit": "^4.5.0",
        "lodash.omitby": "4.6.0",
        "pkginfo": "^0.4.1",
        "ramda": "^0.28.0",
        "randexp": "^0.5.3"
      },
      "engines": {
        "node": ">=16"
      }
    },
    "node_modules/@pact-foundation/pact-core": {
      "version": "14.0.4",
      "resolved": "https://registry.npmjs.org/@pact-foundation/pact-core/-/pact-core-14.0.4.tgz",
      "integrity": "sha512-Vd09KztRQhkepPa6dDQSVWxRDmYapOF18R2V+Xz6VZqjZjaUEr2BHV6YSNj7+/Cz+2wgRu1soDdDZrzCUip2dQ==",
      "cpu": [
        "x64",
        "ia32",
        "arm64"
      ],
      "hasInstallScript": true,
      "os": [
        "darwin",
        "linux",
        "win32"
      ],
      "dependencies": {
        "chalk": "4.1.2",
        "check-types": "7.3.0",
        "cross-spawn": "7.0.3",
        "mkdirp": "1.0.0",
        "needle": "^3.2.0",
        "node-gyp-build": "^4.6.0",
        "pino": "^8.7.0",
        "pino-pretty": "^9.1.1",
        "promise-timeout": "1.3.0",
        "rimraf": "2.6.2",
        "underscore": "1.12.1",
        "unixify": "1.0.0"
      },
      "bin": {
        "pact": "bin/pact.js",
        "pact-broker": "bin/pact-broker.js",
        "pact-message": "bin/pact-message.js",
        "pact-mock-service": "bin/pact-mock-service.js",
        "pact-provider-verifier": "bin/pact-provider-verifier.js",
        "pact-stub-service": "bin/pact-stub-service.js",
        "pactflow": "bin/pactflow.js"
      },
      "engines": {
        "node": ">=16"
      }
    },
    }

[omerson]

Fair enough, thanks for your time.

[YOU54F]

it's ok, I have lots of other dev tools on here, so it may be something else afoot on your machine. As said by Matt if you can raise a reproducible example, we would be happy to help take a further look.

Best of luck!

[mefellows]

I think to close this out, a repro would be needed so we can address it, ideally as an issue .

[omerson]

I would gladly provide a repro steps, but I am not sure I know the exact ones.

[omerson]

one more question pls. is version 9.x.x compatible with node 18 ?

[YOU54F]

Yes, depending on platform. If you use Alpine linux you need dependencies, and there is not official support for arm64 on the 9.x branch.

Alpine isn't supported for 10.x upwards due to reasons listed on this page https://docs.pact.io/docker#for-pact-implementations-that-use-the-rust-shared-core-or

A Dockerfile that will build for arm64/amd64 using a node 18 alpine image, using the 9.x branch using this test repo https://github.com/YOU54F/pact-matchers

# ARM64 platforms not supports by v9.x of pact-js as it usess
# pact-ruby-standalone v1.x which does not support ARM64
FROM --platform=linux/amd64 node:18-alpine
RUN apk --no-cache add gcompat libc6-compat bash git
WORKDIR /usr/app
RUN git clone https://github.com/YOU54F/pact-matchers.git
WORKDIR /usr/app/pact-matchers/pact-js-v2-v9.8.1
RUN npm install
RUN npm run test

# This uses a fork of pact-foundation/pact-js with pact-ruby-standalone v2.x with ARM64 support
FROM --platform=linux/arm64 node:18-alpine
RUN apk --no-cache add gcompat libc6-compat bash git
WORKDIR /usr/app
RUN git clone https://github.com/YOU54F/pact-matchers.git
WORKDIR /usr/app/pact-matchers/pact-js-ruby
RUN git checkout test_you54f_pact
RUN npm install
RUN npm run test