Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: options "width" and "height" #56

Open
bee-mois opened this issue May 29, 2024 · 1 comment
Open

feature request: options "width" and "height" #56

bee-mois opened this issue May 29, 2024 · 1 comment

Comments

@bee-mois
Copy link

bee-mois commented May 29, 2024

options --vp_width and --vp_height would come in handy to be able to set the size of the screencast using viewport, a browser context option coming with playwright.

playwrights viewport default is 1280x720 of width x height.

my usecase needs 1024x1280.

an implementation of two new options --vp_width and --vp_height would be perfect.

it would also be fine with a single option --viewport that takes an integer as input which points to an element of a list of common screen resolutions, like:

[0] 1280x720 (landscape, default)
[1] 720x1280 (portrait)
[2] 1280x1024 (landscape)
[3] 1024x1280 (portrait)
[4] 1680x1050 (landscape)
[5] 1050x1680 (portrait)
[6] 1920x1080 (landscape)
[7] 1080x1920 (portrait)
and so on.

@amotl
Copy link
Member

amotl commented May 29, 2024

Thanks. Let's have flexible options without presets as the primary feature on another iteration. Presets can be built on top, when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants