Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow summary shows failure when the Terminus token is uncached #29

Open
morganestes opened this issue Nov 2, 2024 · 1 comment · May be fixed by #30
Open

Workflow summary shows failure when the Terminus token is uncached #29

morganestes opened this issue Nov 2, 2024 · 1 comment · May be fixed by #30

Comments

@morganestes
Copy link

When using the action, the exit 1 thrown by the cache step bubbles up to the workflow and shows an error even if everything else succeeds.

Is there a way to prevent that error from bubbling, or a different way of cache checking that doesn't return an error exit code?

Screenshot 2024-11-01 at 20-52-29 sites-6227b Test GHA multidev creation after installing a plugin · GannettDigital_websites-gold-upstream@c85284f
Screenshot 2024-11-01 at 20-51-31 sites-6227b Test GHA multidev creation after installing a plugin · GannettDigital_websites-gold-upstream@c85284f
@kyletaylored
Copy link
Contributor

I just came here to post this, I'll work on a PR.

@kyletaylored kyletaylored linked a pull request Nov 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix faulty error output on empty cache kyletaylored/terminus-github-actions
2 participants
@morganestes @kyletaylored