Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy FillTxEnv::fill_tx_env into SignedTransaction trait #12182

Open
emhane opened this issue Oct 30, 2024 · 1 comment · May be fixed by #12186
Open

Copy FillTxEnv::fill_tx_env into SignedTransaction trait #12182

emhane opened this issue Oct 30, 2024 · 1 comment · May be fixed by #12186
Assignees
Labels
A-sdk Related to reth's use as a library D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Oct 30, 2024

Describe the feature

CopyFillTxEnv::fill_tx_env to SignedTransaction and its implementation to impl of SignedTransaction for TransactionSigned and OpTransactionSigned respectively, the latter is blocked by #11433.

/// Fills [`TxEnv`] with an [`Address`] and transaction.
fn fill_tx_env(&self, tx_env: &mut TxEnv, sender: Address);

The trait FillTxEnv will be removed when SignedTransaction trait is integrated into codebase.

Additional context

No response

@emhane emhane added A-sdk Related to reth's use as a library D-good-first-issue Nice and easy! A great choice to get started labels Oct 30, 2024
@garwahl
Copy link
Contributor

garwahl commented Oct 30, 2024

Hey @emhane I can take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
2 participants