Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use global secp256k1 context for tests #12260

Open
mattsse opened this issue Nov 1, 2024 · 2 comments
Open

Use global secp256k1 context for tests #12260

mattsse opened this issue Nov 1, 2024 · 2 comments
Assignees
@Jonatan-Chaverri
Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Nov 1, 2024

Describe the feature

this is predominately used by tests:

https://github.com/search?q=repo%3Aparadigmxyz%2Freth%20%22secp256k1%3A%3Anew%22&type=code

but we can use the global context SECP256K1 instead, this requires global-context feature if not enabled

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled D-good-first-issue Nice and easy! A great choice to get started C-test A change that impacts how or what we test and removed S-needs-triage This issue needs to be labelled labels Nov 1, 2024
@Jonatan-Chaverri
Copy link

Can I work on this one?

@mattsse
Copy link
Collaborator Author

mattsse commented Nov 1, 2024

assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jonatan-Chaverri Jonatan-Chaverri

Labels
C-enhancement New feature or request C-test A change that impacts how or what we test D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsse @Jonatan-Chaverri