Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace TransactionSigned struct inits with new functions #12779

Merged
merged 1 commit into from
Nov 22, 2024
Merged

chore: replace TransactionSigned struct inits with new functions #12779

merged 1 commit into from
Nov 22, 2024

Conversation

htiennv
Copy link
Contributor

@htiennv htiennv commented Nov 22, 2024

Closes #12769

@mattsse mattsse mentioned this pull request Nov 22, 2024
Closed
mattsse
mattsse approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,pending lint

crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/database/provider.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Nov 22, 2024
@htiennv
Copy link
Contributor Author

htiennv commented Nov 22, 2024

Hi @mattsse , i'm just force pushed for resolve conflicts. Please check again, thanks!

mattsse
mattsse approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,ty

@mattsse mattsse added this pull request to the merge queue Nov 22, 2024
Merged via the queue into paradigmxyz:main with commit f286000 Nov 22, 2024
40 checks passed
@htiennv htiennv deleted the txsigned branch November 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace TransactionSigned struct inits with new functions
2 participants
@htiennv @mattsse