-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: eip-7702 #9214
feat: eip-7702 #9214
Conversation
alloy's rpc tx type does not have an auth list because there is currently no rpc spec for eip-7702
Had to do some really ugly manual impls of Hash and Arbitrary, ideally we upstream these to Alloy. The main issue with upstreaming them is the type inside of |
Rfr, CI failures are because of revm bump and there hasn't been a release:) |
bf49020
to
df5495c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
only a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
one outdated test:
thread 'transaction::tx_type::tests::test_u64_to_tx_type' panicked at crates/primitives/src/transaction/tx_type.rs:247:9:
assertion failed: TxType::try_from(U64::from(4)).is_err()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few doc comments and some questions, but overall this looks pretty good
@@ -807,6 +807,7 @@ pub trait Call: LoadState + SpawnBlocking { | |||
chain_id, | |||
blob_versioned_hashes, | |||
max_fee_per_blob_gas, | |||
// authorization_list, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there an alloy issue for tracking 7702 rpc specs, that we can include alongside the TransactionRequest
TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened ethereum/execution-apis#561
but we can go ahead and add rpc support on alloy, will track
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #8680
closes #9428
Supersedes #8895