Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eip-7702 #9214

Merged
merged 36 commits into from
Jul 11, 2024
Merged

feat: eip-7702 #9214

merged 36 commits into from
Jul 11, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Jul 1, 2024

Closes #8680
closes #9428

Supersedes #8895

@onbjerg onbjerg added C-enhancement New feature or request E-prague Related to the prague network upgrade labels Jul 1, 2024
@onbjerg
Copy link
Member Author

onbjerg commented Jul 5, 2024

Had to do some really ugly manual impls of Hash and Arbitrary, ideally we upstream these to Alloy. The main issue with upstreaming them is the type inside of Signature, which for k256 does not implement any of these, so we'd need to work around that. Doable

@onbjerg onbjerg marked this pull request as ready for review July 5, 2024 14:19
@onbjerg
Copy link
Member Author

onbjerg commented Jul 5, 2024

Rfr, CI failures are because of revm bump and there hasn't been a release:)

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

only a few nits

crates/ethereum-forks/src/hardfork/dev.rs Outdated Show resolved Hide resolved
crates/primitives/src/alloy_compat.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types-compat/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-types-compat/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/storage/codecs/src/alloy/authorization_list.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

one outdated test:

thread 'transaction::tx_type::tests::test_u64_to_tx_type' panicked at crates/primitives/src/transaction/tx_type.rs:247:9:
assertion failed: TxType::try_from(U64::from(4)).is_err()

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few doc comments and some questions, but overall this looks pretty good

crates/primitives/src/transaction/eip7702.rs Show resolved Hide resolved
crates/primitives/src/transaction/eip7702.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/eip7702.rs Outdated Show resolved Hide resolved
crates/primitives/src/transaction/tx_type.rs Show resolved Hide resolved
crates/primitives/src/transaction/tx_type.rs Outdated Show resolved Hide resolved
@@ -807,6 +807,7 @@ pub trait Call: LoadState + SpawnBlocking {
chain_id,
blob_versioned_hashes,
max_fee_per_blob_gas,
// authorization_list,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an alloy issue for tracking 7702 rpc specs, that we can include alongside the TransactionRequest TODO?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened ethereum/execution-apis#561
but we can go ahead and add rpc support on alloy, will track

crates/transaction-pool/src/validate/eth.rs Outdated Show resolved Hide resolved
joshieDo and others added 3 commits July 10, 2024 19:27
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Co-authored-by: Dan Cline <6798349+Rjected@users.noreply.github.com>
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattsse mattsse added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit fc4c037 Jul 11, 2024
32 checks passed
@mattsse mattsse deleted the onbjerg/eip-7702 branch July 11, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request E-prague Related to the prague network upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support 7702 handling in txpool Integrate EIP-7702
5 participants