Benchmarked weight too low: Benchmarked storage weight smaller than consumed storage weight.

[skunert]

In the logs I am seeing a lot of Benchmarked storage weight smaller than consumed storage weight..

This indicates that the benchmarking is not correct and transactions are using more weight than they should.

In some cases its not so severe:

2024-08-16 13:17:00 [Parachain] Benchmarked storage weight smaller than consumed storage weight. benchmarked: 11220 consumed: 11227 unspent: 0    

On others the difference is quite high:

2024-08-16 13:17:06 [Parachain] Benchmarked storage weight smaller than consumed storage weight. benchmarked: 18360 consumed: 24368 unspent: 0    

[valentinfernandez1]

Upon looking at the block produced at 2024-08-16 13:17:06 I noticed that the marketplace was interacting with the Escrow pallet, which lead me to look back at PR #69 that updated pallet-marketplace to include an escrow-agent. Although the benchmarks were updated they don't properly reflect the worst path which is were the escrow agent is set to Some(accountId).

This leads to an underestimation of weight:

This is likely one of the root causes, however I will continue to review other pallet benchmarks to ensure that this is not the only problematic benchmark.