Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review benchmarking #237

Open
bkchr opened this issue Sep 19, 2024 · 4 comments
Open

Review benchmarking #237

bkchr opened this issue Sep 19, 2024 · 4 comments

Comments

@bkchr
Copy link
Member

bkchr commented Sep 19, 2024

We are still seeing the following log lines on production:

[Parachain] Benchmarked storage weight smaller than consumed storage weight. benchmarked: 7140 consumed: 10710 unspent: 0 
Node-side PoV size higher than runtime proof size weight. node-side: 66824 extrinsic_len: 11138 runtime: 64767, missing: 2057. Setting to node-side proof size.

We should check which transaction are responsible for these and see if the benchmarking needs to be improved. The second log line is probably related to the BASE_EXTRINSIC weight which is being worked on right now.

@Moliholy
Copy link
Collaborator

@bkchr is paritytech/polkadot-sdk#5594 expected to be released reasonably soon? Otherwise we're blind, as we don't know which exact call is causing the problem and it's pretty hard to find that out.

@bkchr
Copy link
Member Author

bkchr commented Sep 19, 2024

It will be backported to the stable branches

@Moliholy
Copy link
Collaborator

@bkchr does this log entry appear like +1200 times in a single block? Because if so, it could very likely be the migration pallet.

@bkchr
Copy link
Member Author

bkchr commented Sep 19, 2024

No, not that often. It happens way less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants