-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad mobile formatting with TouchKit 5 #17
Comments
TouchKit 5 has a base.css that says "This file contains essential stuff from base theme.", and that contains a lot of commented out stuff. Is any of the comment out stuff related to formatting on mobile devices? |
Related to #15 ? |
I actually figured out a way to fix this last night: go back to where I started with my servlet extending the TouchKitServlet Early on in the Vaadin 8 conversion I couldn't see any difference between extending the VaadinServlet versus extending the TouchKitServlet, so I just extended the VaadinServlet with the theory of keeping things as simple as possible. But extending the TouchKitServlet is necessary to get mobile formatting, and even makes mobile formatting work (more or less) for the valo theme. So I guess this issue can be resolved as not a bug. |
I'm in the process of porting a Vaadin7/TouchKit4 application to Vaadin8/TouchKit5.
I'm at the stage where the application looks similar to the Vaadin7/TouchKit4 version when displaying in a regular web browser on a PC.
However, on a mobile device, the formatting is all squashed up (the font is way too small, for one thing).
The Vaadin7/TouchKit4 version looks like this (this is what it's supposed to look like):
The Vaadin8/TouchKit5 version looks like this:
What might cause this layout difference? And why do I see it only on mobile devices?
The Vaadin7/TouchKit4 version of the code:
https://github.com/steinarb/ukelonn/blob/master/ukelonn.bundle/src/main/java/no/priv/bang/ukelonn/impl/UkelonnUI.java#L30
https://github.com/steinarb/ukelonn/blob/master/ukelonn.bundle/src/main/java/no/priv/bang/ukelonn/impl/UserView.java#L43
The Vaadin8/TouchKit5 version of the code:
https://github.com/steinarb/ukelonn/blob/work/using-vaadin-with-vaadin8/ukelonn.bundle/src/main/java/no/priv/bang/ukelonn/impl/UkelonnUI.java#L29
https://github.com/steinarb/ukelonn/blob/work/using-vaadin-with-vaadin8/ukelonn.bundle/src/main/java/no/priv/bang/ukelonn/impl/UserView.java#L46
I've used chrome development tools simulating an iPhone 5 to make the screen captures, but it is similar to what I see on real mobile devices.
The text was updated successfully, but these errors were encountered: