Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page - review sticky section designs #1286

Closed
mcoker opened this issue Feb 10, 2024 · 4 comments
Closed

Page - review sticky section designs #1286

mcoker opened this issue Feb 10, 2024 · 4 comments
Assignees
Labels
PatternFly 6 Design issues related to Penta work

Comments

@mcoker
Copy link
Contributor

mcoker commented Feb 10, 2024

This is what it looks like now. cc @lboehling

Screenshot 2024-02-09 at 7 06 25 PM
@mcoker mcoker added the PatternFly 6 Design issues related to Penta work label Feb 10, 2024
@srambach srambach transferred this issue from patternfly/patternfly Mar 22, 2024
@andrew-ronaldson andrew-ronaldson self-assigned this Mar 22, 2024
@andrew-ronaldson andrew-ronaldson added PF6 and removed PF6 labels Mar 26, 2024
@andrew-ronaldson
Copy link

andrew-ronaldson commented Apr 9, 2024

Screenshot 2024-04-09 at 8 17 35 PM

This is a possible solution but looking at the code I'm not sure how to make it work. @lboehling @mcoker any feedback on this?

Update:
Unless we add fade/ blurr instead of the shadow (bad example in browser).
Screenshot 2024-04-09 at 8 30 36 PM

@mcoker
Copy link
Contributor Author

mcoker commented Apr 11, 2024

@andrew-ronaldson off the top of my head, I'm not sure if that's possible either - to have the left/right edges of the sticky section span the full width of the content area. The content area has a white border around it now that creates the padding on the inside of the content area, and getting a section to overlap that border will be tricky. It's probably worth revisiting that part of the code and see if there is a better way to do that in a way that lets page sections bleed out to the edges of the main container though, so we could make a spike out of it.

@andrew-ronaldson
Copy link

I'm going to walk back all the nonsense I was saying about the full width border and the blurs/shadows. The only thing I'd like to update is a md spacer at the bottom of the page header content. One wrinkle Breadcrumbs and horizontal navigations need the spacer but the tabs component should not have a bottom spacer.

@andrew-ronaldson
Copy link

Closing this review and created a design kit issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PatternFly 6 Design issues related to Penta work
Projects
Archived in project
Development

No branches or pull requests

2 participants