Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format verse numbers #22

Closed
wants to merge 7 commits into from
Closed

Conversation

jeremiahlukus
Copy link
Collaborator

this is kind of messy and it doesnt add a new directive, however it does format the verse numbers is they are there

Screenshot 2023-10-30 at 2 37 12 PM

One thing to note is that it keeps the padding for the verse number if you have it or not which is something you may not want . I could add a var to LyricsRender called formatVerseNumber and wrap all of that in an if statement.

Screenshot 2023-10-30 at 2 39 59 PM

Like you said in your comment on my issue
#21 (comment)
Adding a new directive would be the ideal solution however this would require me to change 8k songs haha.

Let me know if you can work with this concept

@jeremiahlukus
Copy link
Collaborator Author

Im aligning stuff better than in the pics, but for our purpose assume they align correctly. If everything aligns correctly does this solution work for you

@jeremiahlukus
Copy link
Collaborator Author

I am happier with this:
Screenshot 2023-10-30 at 3 05 25 PM

Screenshot 2023-10-30 at 3 05 40 PM

@jeremiahlukus
Copy link
Collaborator Author

Too much wrong, found a few issues i need to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant