Add optional scroll listener #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paurakhsharma I'm not sure if this is the best way to do this. But I just want to be able to listen to scroll position so I can do some layout adjustments in the parent widget (like show/hide app bar, for example, depending on user scroll). |
|
Hey @jayabrown thank you for the PR. The original author seem to have abandoned this PR but you can take inspiration from this. Please only make changes regarding ScrollController and not bottom and top padding related changes. I believe that would solve what your are trying to achieve? |
|
Ok yes, that method is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional function to be passed in that allows parent widget to listen to the scroll percentage