Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable forge support #333

Open
pcal43 opened this issue Jun 29, 2024 · 2 comments
Open

re-enable forge support #333

pcal43 opened this issue Jun 29, 2024 · 2 comments
Labels

Comments

@pcal43
Copy link
Owner

pcal43 commented Jun 29, 2024

As of 0.18.0+1.20.6, I will no longer be supporting the Forge build of fastback.

  • The Forge version was an experiment that never left alpha. I don't use Forge personally and testing it and keeping the build working has become a chore. My time would be better spent elsewhere.

  • It has been a useful exercise in that it has encouraged a cleaner separation of the non-loader-specific code (in the common module) and that will continue.

  • If anyone in the community is interested in maintaining the Forge build, feel free to send a PR.

  • FWIW, this is the build failure I'm currently getting try to upgrade to 1.20.6. I imagine it's not a difficult fix, but as I say, it's just not really something I want to spend my time on.

Mapping source name conflicts detected:
  net/minecraft/network/protocol/login/custom/DiscardedQueryPayload METHOD write ((Lnet/minecraft/network/FriendlyByteBuf;)V) -> [net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_295630_, net/minecraft/network/protocol/login/custom/DiscardedQueryPayload/m_294761_]
  net/minecraft/network/protocol/login/custom/CustomQueryPayload METHOD write ((Lnet/minecraft/network/FriendlyByteBuf;)V) -> [net/minecraft/network/protocol/login/custom/CustomQueryPayload/m_294761_, net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_295630_]
  net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload METHOD write ((Lnet/minecraft/network/FriendlyByteBuf;)V) -> [net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_295630_, net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_294761_]
  net/minecraftforge/network/ForgePayload METHOD write ((Lnet/minecraft/network/FriendlyByteBuf;)V) -> [net/minecraftforge/network/ForgePayload/m_294761_, net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_295630_]
  net/minecraft/network/protocol/login/custom/DiscardedQueryAnswerPayload METHOD write ((Lnet/minecraft/network/FriendlyByteBuf;)V) -> [net/minecraft/network/protocol/login/custom/CustomQueryAnswerPayload/m_295630_, net/minecraft/network/protocol/login/custom/DiscardedQueryAnswerPayload/m_294761_]
@pcal43 pcal43 added the forge label Jun 29, 2024
@pcal43 pcal43 closed this as completed in 7cfb5e5 Jun 29, 2024
@pcal43 pcal43 reopened this Jun 29, 2024
@Quest79
Copy link

Quest79 commented Jul 8, 2024

Fabric sucks.

@pcal43
Copy link
Owner Author

pcal43 commented Jul 8, 2024

Fabric sucks.

Thanks for the feedback. (But respectfully, I disagree).

As I say, if you or anyone else in the community is interested in helping to maintain forge support in fastback, please reach out.

stewi1014 added a commit to stewi1014/fastback that referenced this issue Nov 18, 2024
Attempts to resolve pcal43#333, but does not fix critical bugs preventing fastback from function on NeoForge.
stewi1014 added a commit to stewi1014/fastback that referenced this issue Nov 19, 2024
Attempts to resolve pcal43#333, but does not fix critical bugs preventing fastback from function on NeoForge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants