From c3bc25962a892937c12eee7261be21fa88e44f29 Mon Sep 17 00:00:00 2001 From: Kevin Cui Date: Thu, 29 Feb 2024 15:01:16 +0800 Subject: [PATCH 1/2] fix(win): incorrect `isElectronApp` logic Ref: https://github.com/electron/electron/blob/13e601e35c43ad640fbe2bfea57e9a054f1dca4c/shell/common/node_bindings.cc#L595-L596 --- src/platforms/win.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platforms/win.ts b/src/platforms/win.ts index bafe07a..e7db47e 100644 --- a/src/platforms/win.ts +++ b/src/platforms/win.ts @@ -92,7 +92,7 @@ const getAppInfoFromRegeditItemValues = async ( function isElectronApp(installDir: string) { return ( fs.existsSync(path.join(installDir, "resources")) && - ["electron.asar", "app.asar", "app.asar.unpacked"].some((file) => + ["default_app.asar", "app.asar", "app.asar.unpacked"].some((file) => fs.existsSync(path.join(installDir, "resources", file)), ) ); From efe25669e571aefa71d04f925e83707f408e59e9 Mon Sep 17 00:00:00 2001 From: Rongjian Zhang Date: Tue, 9 Jul 2024 21:41:49 +0800 Subject: [PATCH 2/2] fixup --- src/main/platforms/win.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/platforms/win.ts b/src/main/platforms/win.ts index 418dd0d..9f0eaec 100644 --- a/src/main/platforms/win.ts +++ b/src/main/platforms/win.ts @@ -92,9 +92,13 @@ const getAppInfoFromRegeditItemValues = async ( function isElectronApp(installDir: string) { return ( fs.existsSync(path.join(installDir, "resources")) && - ["default_app.asar", "app.asar", "app.asar.unpacked"].some((file) => - fs.existsSync(path.join(installDir, "resources", file)), - ) + [ + "electron.asar", + // https://github.com/pd4d10/debugtron/pull/26 + "default_app.asar", + "app.asar", + "app.asar.unpacked", + ].some((file) => fs.existsSync(path.join(installDir, "resources", file))) ); }