Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denied items still have the option as being marked as received. #463

Open
choquette33 opened this issue Jan 12, 2016 · 2 comments
Open

Denied items still have the option as being marked as received. #463

choquette33 opened this issue Jan 12, 2016 · 2 comments

Comments

@choquette33
Copy link
Member

When viewing a denied order on the timeline, I noticed that there was still the ability to mark it as received. The expectations would be that for items that were denied and therefore not sent, the received/flag button would be hidden.

screenshot 2016-01-12 at 1 46 55 pm

@jamesdabbs
Copy link
Member

This isn't entirely trivial, as those buttons are for marking a Response as received or not, and it's possible for a Response to have some items which shipped and some which were denied. Any thoughts about what we should do in that case?

@choquette33
Copy link
Member Author

Can we go with this basic logic?

if ALL items in an order are denied
then don't show buttons
else show buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants