From ae63c0691c053a063d89054da0c90f4d1a86bff4 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Fri, 1 Jul 2016 13:33:42 +0200 Subject: [PATCH] Remove the dart:developer library from .platform files. We do not currently support this library. I think we should add some minimal support in the future and created issue #563. This closes issue: #553 R=karlklose@google.com Review URL: https://codereview.chromium.org/2113273002 . --- lib/dartino_embedded.platform | 1 - lib/dartino_mobile.platform | 1 - pkg/dartino/lib/_embedder.yaml | 1 - tests/language.status | 8 ++++++++ 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/dartino_embedded.platform b/lib/dartino_embedded.platform index 3755bfa4..d4da58a7 100644 --- a/lib/dartino_embedded.platform +++ b/lib/dartino_embedded.platform @@ -24,7 +24,6 @@ core: core/embedded_core.dart math: ../third_party/dart/sdk/lib/math/math.dart typed_data: ../third_party/dart/sdk/lib/typed_data/typed_data.dart -developer: ../third_party/dart/sdk/lib/developer/developer.dart collection: ../third_party/dart/sdk/lib/collection/collection.dart _internal: ../third_party/dart/sdk/lib/internal/internal.dart diff --git a/lib/dartino_mobile.platform b/lib/dartino_mobile.platform index 4ecc9321..8c0466ff 100644 --- a/lib/dartino_mobile.platform +++ b/lib/dartino_mobile.platform @@ -23,7 +23,6 @@ async: ../third_party/dart/sdk/lib/async/async.dart collection: ../third_party/dart/sdk/lib/collection/collection.dart convert: ../third_party/dart/sdk/lib/convert/convert.dart core: ../third_party/dart/sdk/lib/core/core.dart -developer: ../third_party/dart/sdk/lib/developer/developer.dart math: ../third_party/dart/sdk/lib/math/math.dart typed_data: ../third_party/dart/sdk/lib/typed_data/typed_data.dart diff --git a/pkg/dartino/lib/_embedder.yaml b/pkg/dartino/lib/_embedder.yaml index fcb06445..0610ae9a 100644 --- a/pkg/dartino/lib/_embedder.yaml +++ b/pkg/dartino/lib/_embedder.yaml @@ -14,6 +14,5 @@ embedded_libs: 'dart:dartino._ffi': '../../../internal/dartino_lib/ffi/ffi_private.dart' 'dart:dartino.os': '../../../lib/os/os.dart' 'dart:dartino.service': '../../../lib/service/service.dart' - 'dart:developer': '../../../third_party/dart/sdk/lib/developer/developer.dart' 'dart:math': '../../../third_party/dart/sdk/lib/math/math.dart' 'dart:typed_data': '../../../third_party/dart/sdk/lib/typed_data/typed_data.dart' diff --git a/tests/language.status b/tests/language.status index 634f5e2f..5cb2657c 100644 --- a/tests/language.status +++ b/tests/language.status @@ -845,6 +845,14 @@ not_enough_positional_arguments_test/01: CompileTimeError not_enough_positional_arguments_test/05: CompileTimeError not_enough_positional_arguments_test/02: CompileTimeError +# These tests are written expecting dart:developer to always be present. +# We want to support at least parts of dart:developer - issue #562. +library_env_test/none: RuntimeError +library_env_test/has_io_support: RuntimeError +library_env_test/has_no_mirror_support: RuntimeError +library_env_test/has_no_html_support: RuntimeError +library_env_test/has_html_support: RuntimeError + [ $system == lk ] await_for_test: Crash bit_operations_test/01: Crash