Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document why removal must be guarded, or remove the guard #171

Open
samreid opened this issue Dec 6, 2020 · 0 comments
Open

Document why removal must be guarded, or remove the guard #171

samreid opened this issue Dec 6, 2020 · 0 comments
Assignees
@jonathanolson

Comments

@samreid
Copy link
Member

samreid commented Dec 6, 2020

In phetsims/axon#332 we removed the guard from createObservableArray removal methods. I added a sim-specific guard in the following commit, but I'm not sure if it should be documented or eliminated. Assigning to responsible dev to take a look:

6dbcf46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid