Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest better docs for setSustainBegin and End #70

Open
DoctorNerve opened this issue Oct 24, 2018 · 1 comment
Open

Suggest better docs for setSustainBegin and End #70

DoctorNerve opened this issue Oct 24, 2018 · 1 comment
Assignees

Comments

@DoctorNerve
Copy link
Collaborator

I think it would be helpful to document SequentialDataCommon
setSustainBegin better (I don't believe there's any javadoc comment for
it currently). I'd even suggest a simple diagram of, say a four frame
breakpoint envelope with the frames labelled 0, 1, 2, 3 and arrows
showing from where to where it'll loop based on setSustainBegin and
setSustainEnd. Same from setReleaseBegin/End
segmentedenvelope copy

@philburk
Copy link
Owner

I added some Javadocs to setSustainBegin and setSustainEnd(). I will add the diagram in the user guide.

@philburk philburk self-assigned this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants