Replies: 2 comments 1 reply
-
|
@npalm any opinions on this? I highly agree on this. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry missed this discussion. If you still intereset, let's start a discussion on how we can support this and what the impact is. |
Beta Was this translation helpful? Give feedback.
-
|
The impact is that we would just swap the Parameter Store with the Secretsmanager - the question is if we want to keep both variants or just replace it. Otherwise everything is expected to be working the same just with the additional features Secretsmanager is offering. What would you say @npalm? |
Beta Was this translation helpful? Give feedback.
-
I would like to pass in a secretsmanager JSON secret to the module with all necessary GitHub secrets. This makes it easier to implement automatic rotation and it's definitely the more modern service to store secrets.
The only reason why I didn't create a pull-request for that directly is because I'm not sure if I should keep it backward compatible or introduce a breaking change to keep the terraform code simple. Any thoughts about this?
Beta Was this translation helpful? Give feedback.
All reactions