Using fabs() function instead abs() #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
requested changes
Mar 12, 2018
| @@ -460,7 +460,7 @@ geo_lat_long cartesian_to_polar(double x, double y, double z, geo_ellipsoid eli) | |||
| double phi = atan2(z, p * (1 - eSq)); | |||
| double phiP = 2 * M_PI; | |||
|
|
|||
| while (abs(phi - phiP) > precision) { | |||
| while (fabs(phi - phiP) > precision) { | |||
There was a problem hiding this comment.
This PR made one of the tests fail: https://travis-ci.org/php-geospatial/geospatial/jobs/351708921#L643
Can you investigate whether the new value is correct, as the loop where you changed abs to fabs might now run once more or less?
There was a problem hiding this comment.
I have warning when compile geospatil.so in FreeBSD 10.3. Warning saying about using fabs instead abs. When I changed abs to fabs warning is gone!
There was a problem hiding this comment.
That's fine, but it breaks a test if you change it. So either the test is wrong, or something else is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix resolving compilation warning when making so.