Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected house number range splitting #23

Open
larsbo opened this issue Sep 11, 2018 · 1 comment
Open

Unexpected house number range splitting #23

larsbo opened this issue Sep 11, 2018 · 1 comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".

Comments

@larsbo
Copy link

larsbo commented Sep 11, 2018

House number ranges should not be splitted because since both parts are meaningless on their own in my opinion and you usually want to use the number (range) in one piece.

[
    'Happy Street 2-4',
    [
        'additionToAddress1' => '',
        'streetName'         => 'Happy Street',
        'houseNumber'        => '2-4',
        'additionToAddress2' => ''
    ]
]
@svenmuennich svenmuennich added bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major". labels Mar 28, 2019
@dreeh
Copy link

dreeh commented Oct 5, 2023

As of version 0.3.4, it's already fixed?

running

AddressSplitter::splitAddress('Happy Street 2-4')

gives the output:

Array
(
    [additionToAddress1] =>
    [streetName] => Happy Street
    [houseNumber] => 2-4
    [houseNumberParts] => Array
        (
            [base] => 2
            [extension] => 4
        )

    [additionToAddress2] =>
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that describe an unexpected behaviour in an existing functionality. minor "bug" issues that are neither "critical" nor "major".
Projects
None yet
Development

No branches or pull requests

3 participants