Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create homeDir if it doesn't exist alredy #246

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

neroist
Copy link
Contributor

@neroist neroist commented Jun 29, 2024

Title is self-explanitory -- unsure if the directory's creation should be logged or not (probably not?)

@pietroppeter
Copy link
Owner

yep, self explanatory and straightforward fix to a "bug" we did not know about. Thanks!

Looking at this

log "creating directory: " & dir

I would say for consistency to log directory creation. (and I think in general looks a good thing to log by default changes to the environment, since we are defaulting for now to a rather verbose nimib).

@pietroppeter pietroppeter merged commit 5454182 into pietroppeter:main Jul 10, 2024
7 checks passed
@pietroppeter
Copy link
Owner

Thanks, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants