Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: icon image path error #107

Closed
mhgtlc opened this issue May 24, 2023 · 13 comments
Closed

[Bug]: icon image path error #107

mhgtlc opened this issue May 24, 2023 · 13 comments
Assignees
Milestone

Comments

@mhgtlc
Copy link
Contributor

mhgtlc commented May 24, 2023

Error: Uncaught ReferenceError: L is not defined

file: public/js/pimcore/startup.js:962

L.Icon.Default.imagePath = '../bundles/pimcoreadmin/build/admin/images/';
@mhgtlc mhgtlc changed the title icon image path error [Bug]: icon image path error May 24, 2023
@brusch brusch added this to the 1.0.1 milestone May 24, 2023
@brusch brusch added the Bug label May 24, 2023
@robertSt7 robertSt7 modified the milestones: 1.0.1, 1.0.2 May 31, 2023
@robertSt7 robertSt7 modified the milestones: 1.0.2, 1.0.3 Jun 21, 2023
@robertSt7 robertSt7 modified the milestones: 1.0.3, 1.0.4 Jul 6, 2023
@aryaantony92
Copy link
Contributor

Unable to reproduce the error. It's working now

@robertSt7 robertSt7 removed this from the 1.0.4 milestone Jul 14, 2023
@mhgtlc
Copy link
Contributor Author

mhgtlc commented Jul 16, 2023

@aryaantony92

Unable to reproduce the error. It's working now

The error is still there:

https://github.com/pimcore/admin-ui-classic-bundle/blob/1.x/public/js/pimcore/startup.js#L962C1-L962C3
Where does this L come from?

@aryaantony92
Copy link
Contributor

@mhgtlc Could you please try again with the latest version ?

@aryaantony92 aryaantony92 reopened this Jul 17, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Jul 18, 2023

@aryaantony92 @mhgtlc L. is a leaflet object (used mainly for Geo datatypes). I'm wondering why this is not part of admin bundle? 🤔

@aryaantony92
Copy link
Contributor

L.Icon.Default.imagePath = '../bundles/pimcoreadmin/build/admin/images/';
This is in the admin bundle.

@storbahn
Copy link
Contributor

I still have this error L.Icon.Default.imagePath = '../bundles/pimcoreadmin/build/admin/images/'; (js error in browser console)

We use the pimcore version 11.1.5 and the admin bundle with version 1.3.4

@aarongerig
Copy link
Contributor

aarongerig commented Feb 21, 2024

Same here. I get a L is not defined error in the console, when loading the Pimcore Backend.

@dvesh3 This issue should be re-opened as it doesn't seem to be fixed, right?

@aarongerig
Copy link
Contributor

@dvesh3 WDYT? 🙂

@sevarozh
Copy link

I can also confirm it with:

  • pimcore/pimcore 11.1.4
  • pimcore/admin-ui-classic-bundle 1.3.1

It looks like the "Leaflet" library is loaded later than L.Icon.Default.imagePath is called in startup.js.
After loading of admin, L is defined in console:
Bildschirmfoto 2024-03-28 um 11 37 49

Issue is closed, but I can't find a commit with a bug fix @aryaantony92

@mhgtlc
Copy link
Contributor Author

mhgtlc commented Apr 10, 2024

@brusch @dvesh3 @aryaantony92
Issue is still there:

  • pimcore/pimcore 11.2.2
  • pimcore/admin-ui-classic-bundle 1.4.0

And indeed, behaviour is the same as @sevarozh described above (It looks like the "Leaflet" library is loaded later than L.Icon.Default.imagePath is called in startup.js)

@fashxp fashxp reopened this Apr 10, 2024
@fashxp
Copy link
Member

fashxp commented Apr 10, 2024

can you share more detailed steps to reproduce?
can it be reproduced on our demo?

@robertSt7
Copy link
Contributor

@mhgtlc @sevarozh @aarongerig @storbahn Could you please test if this patch fix the problem? TIA
#697

@aarongerig
Copy link
Contributor

aarongerig commented Sep 24, 2024

@robertSt7 This indeed resolves the issue on my side. 👍🏻

@robertSt7 robertSt7 added this to the 1.5.5 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants