-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many-to-many object relation / multiselect in tag mode: support drag & drop to change order of assigned items #547
Conversation
…& drop to change order of asigned items
…& drop to change order of asigned items
Quality Gate passedIssues Measures |
Hi @BlackbitDevs could you please replace |
@robertSt7 Done. |
Quality Gate passedIssues Measures |
We don't want to be picky, but we need to be careful with compliance and copyrights. So, I'm sorry, we cannot merge this PR, as it includes code from a foreign author that has not signed our CLA.
|
@adamborowski is the code in https://fiddle.sencha.com/fiddle/i65/preview from you? Would it be ok to use it in Pimcore? |
Sure |
@fashxp Is above comment enough? |
yes it is, thx very much @adamborowski. maybe we can translate the comments to english, test once more then it is ready to merge. |
Have translated the comments. |
Quality Gate passedIssues Measures |
Thanks, looks good to me. |
Assume we have a many-to-many object relation in display mode = tag field.
When assigning new objects, everything works great but sometimes the order of the assigned items matters and you want to insert an item in between or change the order of already assigned items.
So if you have assigned objects
/one
and/three
and now want to insert/two
in between, then you have to currently/three
/two
/three
This is quite complicated. And depending on number of assigned elements, this is can be even more work.
This PR adds drag & drop support for the assigned items. It works like in https://fiddle.sencha.com/fiddle/i65/preview
With this you can change the order of assigned objects afterwards.
The same functionality has also been applied to multiselect fields in tag mode.