Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

426 emtpy screen notes events #459

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Conversation

xIrusux
Copy link
Contributor

@xIrusux xIrusux commented Aug 8, 2024

Changes in this pull request

empty screen for notes and events

image

Resolves #426

@xIrusux xIrusux requested a review from vin0401 August 8, 2024 16:25
@markus-moser
Copy link
Contributor

@xIrusux Please always add a link to the resolved issue to your PR like this, thanks:

Resolves #426

Copy link
Collaborator

@vin0401 vin0401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks good to me, but aren't we missing the button to add items to the list? :P

@xIrusux xIrusux requested a review from vin0401 August 12, 2024 09:44
@xIrusux
Copy link
Contributor Author

xIrusux commented Aug 12, 2024

:)

Screen.Recording.2024-08-12.at.11.44.44.mov

also tiny clean up of some bits as few styles are out of the box with flex anyway. Let me know if we rather want to be explicit.

EDIT: made header bold so to match with most other headers we are not mega consistent here

Copy link

sonarcloud bot commented Aug 12, 2024

@markus-moser markus-moser self-requested a review August 13, 2024 06:53
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works like it should. The bold headline is correct. At the end the headline should be bold in all tabs. We should create a shared component for this, but let's create a separate issue for this.

@markus-moser
Copy link
Contributor

Separate issue for the headline topic #463

@markus-moser markus-moser merged commit fe40261 into 1.x Aug 13, 2024
@markus-moser markus-moser deleted the 426-emtpy-screen-notes-events branch August 13, 2024 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notes&Events] Implement empty screen
3 participants