Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade script for existing default masthead roles and user assignments #10041

Closed
bozana opened this issue Jun 12, 2024 · 3 comments
Closed

Upgrade script for existing default masthead roles and user assignments #10041

bozana opened this issue Jun 12, 2024 · 3 comments
Assignees
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Jun 12, 2024

Existing default masthead roles (editor, section editor and reviewer) should be considered to be displayed on the masthead.
All existing user-role assignments -- not only assignments to the masthead roles, but to all roles -- should be also considered to be displayed on the masthead.

PRs:

@bozana bozana self-assigned this Jun 12, 2024
@bozana bozana added the Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. label Jun 12, 2024
@bozana bozana modified the milestones: 3.5 Internal, 3.5.0 LTS Jun 12, 2024
bozana added a commit to bozana/pkp-lib that referenced this issue Jun 12, 2024
bozana added a commit to bozana/ojs that referenced this issue Jun 12, 2024
bozana added a commit to bozana/ojs that referenced this issue Jun 12, 2024
@bozana
Copy link
Collaborator Author

bozana commented Jun 12, 2024

@asmecher, could you please review the PRs above?
Thanks a lot!

@asmecher
Copy link
Member

Please go ahead, @bozana. My only thought is that we haven't considered OMP, where there are also internal reviewers that should possibly be listed. It might be worth checking with John about that.

bozana added a commit to bozana/pkp-lib that referenced this issue Jun 13, 2024
bozana added a commit to bozana/ojs that referenced this issue Jun 13, 2024
bozana added a commit to bozana/ojs that referenced this issue Jun 13, 2024
bozana added a commit to bozana/omp that referenced this issue Jun 13, 2024
bozana added a commit to bozana/omp that referenced this issue Jun 13, 2024
bozana added a commit to bozana/ops that referenced this issue Jun 13, 2024
bozana added a commit to bozana/ops that referenced this issue Jun 13, 2024
@bozana
Copy link
Collaborator Author

bozana commented Jun 13, 2024

Good catch, @asmecher! -- I currently do not differentiate between internal and external reviewers for display -- I just consider all reviewers from review_assignments table that have completed a review -- but I have not marked the role "Internal Reviewer" to be considered on the masthead :-
I have just asked John... and will repair accordingly...
Thanks a lot!

@bozana bozana mentioned this issue Jun 13, 2024
20 tasks
bozana added a commit that referenced this issue Jun 13, 2024
#10041 Consider existing default masthead roles and all us…
bozana added a commit to pkp/ojs that referenced this issue Jun 13, 2024
pkp/pkp-lib#10041 Upgrade script for existing default masthead roles and user assignments
bozana added a commit to pkp/omp that referenced this issue Jun 13, 2024
pkp/pkp-lib#10041 Upgrade script for existing default masthead roles and user assignments
bozana added a commit to pkp/ops that referenced this issue Jun 13, 2024
pkp/pkp-lib#10041 Upgrade script for existing default masthead roles and user assignments
@bozana bozana closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days.
Projects
Status: Done
Development

No branches or pull requests

2 participants