Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing date when editor confirmed review in API #10359

Open
jardakotesovec opened this issue Sep 3, 2024 · 5 comments
Open

Exposing date when editor confirmed review in API #10359

jardakotesovec opened this issue Sep 3, 2024 · 5 comments
Assignees
@Vitaliy-1 @Hafsa-Naeem @pkp-dev-workflow
Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. UI/UX Issues affecting the user interface/user experience
Milestone
3.5.0 LTS

Comments

@jardakotesovec
Copy link
Contributor

Describe the issue
One item initially I missed is that we would like to display date when editor confirms the review. Ideally it would be also the name, but at least date would suffice.

I currently use dateDue, dateResponseDue, dateCompleted, dateCancelled for these popups, but date for confirmation is not currently not available - we might not even track that in database.

Screenshot 2024-09-03 at 10 10 48

What application are you using?
OJS, OMP or OPS version 3.5
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Sep 3, 2024
@jardakotesovec
Copy link
Contributor Author

Hi @Vitaliy-1, sorry missed this one before. Would be possible still to add that?

@jardakotesovec jardakotesovec added Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. UI/UX Issues affecting the user interface/user experience labels Sep 3, 2024
@jardakotesovec jardakotesovec mentioned this issue Sep 3, 2024
Open
21 tasks
@Vitaliy-1 Vitaliy-1 self-assigned this Sep 9, 2024
@Hafsa-Naeem Hafsa-Naeem self-assigned this Sep 13, 2024
Hafsa-Naeem added a commit to Hafsa-Naeem/pkp-lib that referenced this issue Sep 19, 2024
@Hafsa-Naeem
pkp#10359 Exposing date when editor confirmed review in API with date…
934d433 
…EditorConfirmed
@Hafsa-Naeem Hafsa-Naeem mentioned this issue Sep 19, 2024
Open
Hafsa-Naeem added a commit to Hafsa-Naeem/pkp-lib that referenced this issue Sep 19, 2024
@Hafsa-Naeem
pkp#10359 add migration for the date_editor_confirmed
c2b72f0
@Hafsa-Naeem
Copy link
Contributor

Hafsa-Naeem commented Sep 19, 2024 •
edited
Loading

Ready for review @Vitaliy-1

pkp/pkp-lib: Exposing date when editor confirmed review in API with dateEditorConfirmed #10450

@Vitaliy-1
Copy link
Collaborator

@Hafsa-Naeem, can you also make a PR to OJS main for tests? Now, with Github actions it's also possible to run tests on your fork

Hafsa-Naeem added a commit to Hafsa-Naeem/pkp-lib that referenced this issue Oct 4, 2024
@Hafsa-Naeem
pkp#10359 Exposing date when editor confirmed review in API with date…
c3eca43 
…EditorConfirmed
Hafsa-Naeem added a commit to Hafsa-Naeem/pkp-lib that referenced this issue Oct 4, 2024
@Hafsa-Naeem
pkp#10359 add migration for the date_editor_confirmed
dec9983
Hafsa-Naeem added a commit to Hafsa-Naeem/ojs that referenced this issue Oct 4, 2024
@Hafsa-Naeem
pkp/pkp-lib#10359 Update pkp-lib submodule to include the latest chan…
8b555fc 
…ges for showing editor confirm date
Hafsa-Naeem added a commit to Hafsa-Naeem/ojs that referenced this issue Oct 4, 2024
@Hafsa-Naeem
pkp/pkp-lib#10359 Update pkp-lib submodule to include the correct cha…
c269824 
…nges for showing editor confirm date
Hafsa-Naeem added a commit to Hafsa-Naeem/ojs that referenced this issue Oct 4, 2024
@Hafsa-Naeem
pkp/pkp-lib#10359 Update pkp-lib submodule to include changes related…
ed5a0a7 
… to editor confirm date
@Hafsa-Naeem
Copy link
Contributor

@Vitaliy-1 The tests are passing on the PR to OJS.
OJS: pkp/pkp-lib#10359 Update pkp-lib submodule to include the correct changes for showing editor confirm date #4462

@Vitaliy-1
Copy link
Collaborator

Looks good! Can we also name the column as date_considered following the naming for the considered column?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vitaliy-1 Vitaliy-1

@Hafsa-Naeem Hafsa-Naeem

@pkp-dev-workflow pkp-dev-workflow

Labels
Enhancement:1:Minor A new feature or improvement that can be implemented in less than 3 days. UI/UX Issues affecting the user interface/user experience
Projects
None yet
Milestone
3.5.0 LTS
Development

No branches or pull requests
4 participants
@jardakotesovec @Vitaliy-1 @Hafsa-Naeem @pkp-dev-workflow