Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Year over Year" comparison mode #2704

Merged
merged 16 commits into from
Mar 7, 2023
Merged

Implement "Year over Year" comparison mode #2704

merged 16 commits into from
Mar 7, 2023

Commits on Feb 28, 2023

  1. Change comparison input to support modes

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    4c6f47b View commit details
    Browse the repository at this point in the history

  2. Add disabled option to comparison UI

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    c240820 View commit details
    Browse the repository at this point in the history

  3. Implement last year comparison mode

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    44e506e View commit details
    Browse the repository at this point in the history

  4. Fix comparison input text color in dark mode

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    9af66ed View commit details
    Browse the repository at this point in the history

  5. Fix Credo warnings

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a6c634a View commit details
    Browse the repository at this point in the history

  6. Rename last_year to year_over_year comparison mode

    @vinibrsl
    vinibrsl committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    b174e80 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Move comparisons to its own module

    @vinibrsl
    vinibrsl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6004968 View commit details
    Browse the repository at this point in the history

  2. Apply comparisons to top stats

    @vinibrsl
    vinibrsl committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    960354a View commit details
    Browse the repository at this point in the history

  3. Add some failing tests for comparisons

    @ukutaht
    ukutaht committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    6f7a7f6 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Limit year over year comparison relative to current day

    @vinibrsl
    vinibrsl committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    e4b55ef View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Move shift_back to Comparison module

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7f479be View commit details
    Browse the repository at this point in the history

  2. Change shift_back calls to Comparison.compare

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    da1c092 View commit details
    Browse the repository at this point in the history

  3. Ignore invalid comparison modes

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3c3bd41 View commit details
    Browse the repository at this point in the history

  4. Add more comparison test cases

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7839bde View commit details
    Browse the repository at this point in the history

  5. Refactor previous period functions to use earliest/2

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    3f59376 View commit details
    Browse the repository at this point in the history

  6. Fix compare function typespec

    @vinibrsl
    vinibrsl committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c2d480b View commit details
    Browse the repository at this point in the history