Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html_quote issue #46

Open
marclava opened this issue Nov 5, 2021 · 1 comment
Open

html_quote issue #46

marclava opened this issue Nov 5, 2021 · 1 comment

Comments

@marclava
Copy link

marclava commented Nov 5, 2021

In ResolveUIDAndCaptionFilter.handle_captioned_image, the option:
'caption': newline_to_br(html_quote(caption))
Should be:
'caption': newline_to_br(caption)
Or else apostrophes (and probably other characters transformed by html_quote) are showed as html entities in the captions...

I fixed the issue by monkey-patching handle_captioned_image in my profile package, but that's sub-optimal...
(I won't fork the repo only to submit such a trivial fix)

Thanks for your attention.

@MrTango
Copy link
Contributor

MrTango commented Apr 15, 2022

thx, PR is always welcome ;)
Only requirement is first once to sign the Plone contributor https://docs.plone.org/develop/coredev/docs/agreement.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants