Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hvcc and add dpf-widgets #27

Merged
merged 18 commits into from
Oct 11, 2024

Conversation

dromer
Copy link
Contributor

@dromer dromer commented Jun 21, 2024

No description provided.

@dromer
Copy link
Contributor Author

dromer commented Jun 21, 2024

Still not sure to what extend we can start building UI with dpf-widgets, but at least we can start trying stuff (and code export works).

@dromer dromer marked this pull request as draft June 21, 2024 17:47
@dromer
Copy link
Contributor Author

dromer commented Jun 21, 2024

Needs a bit more testing before merge.

@dromer
Copy link
Contributor Author

dromer commented Sep 20, 2024

Heuhm, trying to update to latest hvcc release and somehow the pyinstaller build exploded o.O

The only dependency I added was pydantic, but that shouldn't add a whopping +100MB to the size ..

@dromer
Copy link
Contributor Author

dromer commented Sep 20, 2024

Looking at moving hvcc to poetry and using the poetry-pyinstaller-plugin this gives a result that's more like expected.
Will need a bit of work to integrate it with the toolchain though.

@dromer
Copy link
Contributor Author

dromer commented Sep 21, 2024

Test going on here: Wasted-Audio/hvcc#199

Creates a single binary that does everything.
I also found the culprit for the generators needing an additional import.

@dromer
Copy link
Contributor Author

dromer commented Sep 27, 2024

Hmm, Windows builds fail due to number of files: https://github.com/Wasted-Audio/plugdata-heavy-toolchain/actions/runs/11065615856

Error: EMFILE: too many open files, open 'D:\a\plugdata-heavy-toolchain\plugdata-heavy-toolchain\Heavy\usr\share\perl5\core_perl\Test\Tester\Capture.pm'

@dromer dromer marked this pull request as ready for review September 27, 2024 07:01
@dromer
Copy link
Contributor Author

dromer commented Sep 27, 2024

So other than Windows archive upload this all should work.

Any suggestion on how to fix this? Recommendation is to first zip the target dir, but then we need another step to unpack it on the plugdata side.

@timothyschoen
Copy link
Collaborator

Looks like this is now fixed by Github: actions/upload-artifact#485

@timothyschoen timothyschoen merged commit b31577a into plugdata-team:main Oct 11, 2024
@timothyschoen
Copy link
Collaborator

Nice though, upload-artifact@v4 should really speed it up

@timothyschoen
Copy link
Collaborator

timothyschoen commented Oct 11, 2024

Perhaps we could find a way to speed up the Windows build still... It spends half of the time downloading and extracting minGW. Feels like that could be faster

@dromer dromer deleted the update/hvcc branch October 11, 2024 14:21
@dromer
Copy link
Contributor Author

dromer commented Oct 11, 2024

yeah it takes quite a long time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants