Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GrubSetup.sh To Better Account For Non-LVM root= #56

Open
ferricoxide opened this issue Oct 18, 2018 · 0 comments
Open

Fix GrubSetup.sh To Better Account For Non-LVM root= #56

ferricoxide opened this issue Oct 18, 2018 · 0 comments
Labels
bug

Comments

@ferricoxide
Copy link
Member

Problem Description:

When generating new "recovery" AMIs, the GrubSetup.sh currently sets the root= token to the chroot-built device's real devnode rather than properly referencing its LABEL value

Expected Behavior:

The root= tokens in the chroot()ed /boot/grub2/grub.cfg should be set to root=LABEL=<LABEL>

Actual Behavior:

The root= tokens in the chroot()ed /boot/grub2/grub.cfg are set to root=/chroot/devnode

(Detailed) Steps to reproduce:

Run GrubSetup.sh to create non-LVM'ed AMI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ferricoxide