Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Nonce edit #396

Open
tobutridaz opened this issue Jul 6, 2020 · 4 comments
Open

Feature request: Nonce edit #396

tobutridaz opened this issue Jul 6, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@tobutridaz
Copy link

Feature request: A settings toggle that would add a nonce field for all transactions, allowing to override the default nonce.

Scenario: On Ethereum network, when a txn is underpriced with gas, instead of speeding it, the transaction might become redundant at certain time, so a replacing it with a completely different transaction is useful, but requires to override nonce for the new transaction.

@vbaranov
Copy link
Collaborator

vbaranov commented Jul 7, 2020

@tobutridaz it is already possible to set custom nonce for any transaction. It has been implemented in this PR #379. And this feature is available in the currently published Nifty wallet 5.1.1. Isn't this you are looking for?

@tobutridaz
Copy link
Author

I'm running 5.1.1 and below is a transaction popup after interacting with a dapp. Where do I edit the nonce?
brave_2020-07-08_10-45-28

@vbaranov vbaranov added the enhancement New feature or request label Jul 8, 2020
@vbaranov
Copy link
Collaborator

vbaranov commented Jul 8, 2020

Oh yes. I see it now. The nonce's editing is available in a previous screen when someone sends tx from the wallet itself. And there is no way to get to that previous screen if transaction originated from dApp. I should open access to that previous screen from the confirmation screen.

@tobutridaz
Copy link
Author

Yes please, or just add a nonce field on the confirm tx window as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants