From e91d3779f724d6d8225d401ad89fc6019a69576c Mon Sep 17 00:00:00 2001 From: Justin Coyne Date: Thu, 4 Jan 2024 08:35:36 -0600 Subject: [PATCH] Fix capybara rubocop --- spec/features/nav_dropdown_spec.rb | 2 +- spec/features/providers_spec.rb | 12 ++++++------ spec/features/unprivileged_user_spec.rb | 6 +++--- spec/views/dashboard/summary.html.erb_spec.rb | 2 +- .../layout_manage_organization.html.erb_spec.rb | 2 +- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/spec/features/nav_dropdown_spec.rb b/spec/features/nav_dropdown_spec.rb index 2f4f7a85..ea66651d 100644 --- a/spec/features/nav_dropdown_spec.rb +++ b/spec/features/nav_dropdown_spec.rb @@ -63,7 +63,7 @@ end it 'Does not show affiliated organization manage link' do - expect(page).not_to have_link 'Manage Best University' + expect(page).to have_no_link 'Manage Best University' end it 'Shows affiliated organization home link' do diff --git a/spec/features/providers_spec.rb b/spec/features/providers_spec.rb index b124546f..88a5170a 100644 --- a/spec/features/providers_spec.rb +++ b/spec/features/providers_spec.rb @@ -22,9 +22,9 @@ visit organizations_url # don't confuse "Edit" with "Edit Profile" in header nav - expect(page).not_to have_link('Edit', exact: true) - expect(page).not_to have_link 'Delete' - expect(page).not_to have_link 'New Organization' + expect(page).to have_no_link('Edit', exact: true) + expect(page).to have_no_link 'Delete' + expect(page).to have_no_link 'New Organization' end end @@ -51,11 +51,11 @@ it 'lists some limited information about the org' do visit organization_url(organization) - expect(page).not_to have_selector 'h2', text: 'Access Tokens' - expect(page).not_to have_selector 'h2', text: 'Users' + expect(page).to have_no_selector 'h2', text: 'Access Tokens' + expect(page).to have_no_selector 'h2', text: 'Users' expect(page).to have_content '1297245.marc' - expect(page).not_to have_link 'Download' + expect(page).to have_no_link 'Download' end end diff --git a/spec/features/unprivileged_user_spec.rb b/spec/features/unprivileged_user_spec.rb index ed6d73de..7727ee90 100644 --- a/spec/features/unprivileged_user_spec.rb +++ b/spec/features/unprivileged_user_spec.rb @@ -21,10 +21,10 @@ it 'lists some limited information about the org' do visit organization_url(organization) - expect(page).not_to have_selector 'h2', text: 'Access Tokens' - expect(page).not_to have_selector 'h2', text: 'Users' + expect(page).to have_no_selector 'h2', text: 'Access Tokens' + expect(page).to have_no_selector 'h2', text: 'Users' expect(page).to have_content '1297245.marc' - expect(page).not_to have_link 'Download' + expect(page).to have_no_link 'Download' end end diff --git a/spec/views/dashboard/summary.html.erb_spec.rb b/spec/views/dashboard/summary.html.erb_spec.rb index 2ef6b974..c57f3a2e 100644 --- a/spec/views/dashboard/summary.html.erb_spec.rb +++ b/spec/views/dashboard/summary.html.erb_spec.rb @@ -56,6 +56,6 @@ it 'does not render the activity summary tabs on page 2 of uploads' do assign(:uploads, Kaminari.paginate_array(uploads1).page(2)) - expect(rendered).not_to have_css('ul#summary-tabs') + expect(rendered).to have_no_css('ul#summary-tabs') end end diff --git a/spec/views/shared/layout_manage_organization.html.erb_spec.rb b/spec/views/shared/layout_manage_organization.html.erb_spec.rb index e3eded57..79dec0d8 100644 --- a/spec/views/shared/layout_manage_organization.html.erb_spec.rb +++ b/spec/views/shared/layout_manage_organization.html.erb_spec.rb @@ -27,7 +27,7 @@ it 'does not link to Provider home for consumer orgs' do render - expect(view.content_for(:org_header)).not_to have_link 'Provider home' + expect(view.content_for(:org_header)).to have_no_link 'Provider home' end end end