Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce hardcoded input and output shapes #3

Open
2martens opened this issue Feb 6, 2019 · 0 comments
Open

Reduce hardcoded input and output shapes #3

2martens opened this issue Feb 6, 2019 · 0 comments

Comments

@2martens
Copy link

2martens commented Feb 6, 2019

In the train_AAE.py file a zsize of 32 is defined. But it is not consistently used. Sometimes the number 32 is used directly which makes it difficult to modify the code for different image sizes.

It would be helpful if you could clearly use variables designated channels, height, width and zsize (should that be different from height/width) instead of hardcoded values wherever channels, height, width or zsize are effectively used. This should be applied to the network definitions as well.

This would make it significantly easier to port your work to other datasets and/or Tensorflow/Keras.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant